updated drop_tip() docstring, added a todo

Opentrons · Sep 12, 2023 · 31524d8 · 31524d8
1 parent 646881e
commit 31524d8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/api/known_hosts b/api/known_hosts
@@ -0,0 +1 @@
+10.13.11.228 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDJZG8k0SErZ3sYdeefq99QjSvSKRvVf2Dq1JlsKwpKd1BUcJlFO4ZPiWmNkrWrc/EQPnB5Rkao5OAiCph2X6ac2hudhAnNfrojrR8EOmqL7rZQiH+Cou5sZ6EH8U1AT98oF4uezkLT8eRj7g4I3IXR5f6c3effja415Lm5hugT+LPOD6VQvJjFpeR9QvLgmTY6vvwybPuBoHhWzG8V4zVskid62I72h2H79TacOEOPh6i9OpXDm80e6B21skbHGJEeeMN1GXAkn/bWDJuIOAZd7dtdjt4B9zEhN8FXNRYrv/PbvmlpcXN+Wl9e1AYMeFFtwIzoI67gddi73goGMMzn
diff --git a/api/src/opentrons/protocol_api/instrument_context.py b/api/src/opentrons/protocol_api/instrument_context.py
@@ -862,8 +862,9 @@ def drop_tip(
 
         If no location is passed, the Pipette will drop the tip into its
         :py:attr:`trash_container`, which if not specified defaults to
-        the fixed trash in slot 12.  From API version 2.15 on, the API will default to
-        alternating between two different drop tip locations within the trash container
+        the fixed trash in slot 12.  From API version 2.15 on, if the trash container is
+        the default fixed trash in A3 (slot 12), the API will default to
+        dropping tips at different points within the trash container
         in order to prevent tips from piling up in a single location in the trash.
 
         The location in which to drop the tip can be manually specified with

diff --git a/api/src/opentrons/protocol_engine/state/geometry.py b/api/src/opentrons/protocol_engine/state/geometry.py
@@ -552,6 +552,8 @@ def get_next_tip_drop_location(
             # In order to avoid the complexity of finding tip drop locations for
             # variety of labware with different well configs, we will allow
             # location cycling only for fixed trash labware right now.
+            # TODO (spp, 2023-09-12): update this to possibly a labware-width based check,
+            #  or a 'trash' quirk check, once movable trash is implemented.
             return DropTipWellLocation(
                 origin=DropTipWellOrigin.DEFAULT,
                 offset=WellOffset(x=0, y=0, z=0),
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		10.13.11.228 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDJZG8k0SErZ3sYdeefq99QjSvSKRvVf2Dq1JlsKwpKd1BUcJlFO4ZPiWmNkrWrc/EQPnB5Rkao5OAiCph2X6ac2hudhAnNfrojrR8EOmqL7rZQiH+Cou5sZ6EH8U1AT98oF4uezkLT8eRj7g4I3IXR5f6c3effja415Lm5hugT+LPOD6VQvJjFpeR9QvLgmTY6vvwybPuBoHhWzG8V4zVskid62I72h2H79TacOEOPh6i9OpXDm80e6B21skbHGJEeeMN1GXAkn/bWDJuIOAZd7dtdjt4B9zEhN8FXNRYrv/PbvmlpcXN+Wl9e1AYMeFFtwIzoI67gddi73goGMMzn