address comments

Opentrons · Mar 26, 2024 · 2f97910 · 2f97910
1 parent fbb7278
commit 2f97910
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 18 deletions.
diff --git a/app/src/organisms/Devices/ProtocolRun/ProtocolRunRunTimeParameters.tsx b/app/src/organisms/Devices/ProtocolRun/ProtocolRunRunTimeParameters.tsx
@@ -10,10 +10,10 @@ import {
   DIRECTION_COLUMN,
   DIRECTION_ROW,
   Flex,
-  NoParameters,
   SPACING,
   StyledText,
   TYPOGRAPHY,
+  NoParameters,
 } from '@opentrons/components'
 
 import { Banner } from '../../../atoms/Banner'

diff --git a/app/src/organisms/Devices/ProtocolRun/__tests__/ProtocolRunRuntimeParameters.test.tsx b/app/src/organisms/Devices/ProtocolRun/__tests__/ProtocolRunRuntimeParameters.test.tsx
@@ -14,10 +14,9 @@ import type {
   CompletedProtocolAnalysis,
   RunTimeParameter,
 } from '@opentrons/shared-data'
-import type * as Components from '@opentrons/components'
 
 vi.mock('@opentrons/components', async importOriginal => {
-  const actual = await importOriginal<typeof Components>()
+  const actual = await importOriginal<typeof NoParameters>()
   return {
     ...actual,
     NoParameters: vi.fn(),

diff --git a/components/src/index.ts b/components/src/index.ts
@@ -22,7 +22,7 @@ export * from './tabbedNav'
 export * from './slotmap'
 export * from './structure'
 export * from './tooltips'
-export * from './ParametersTable'
+
 // styles
 export * from './styles'
 // new ui-overhaul style vars

diff --git a/...ents/src/parametersTable/NoParameters.tsx → ...olecules/ParametersTable/NoParameters.tsx b/...ents/src/parametersTable/NoParameters.tsx → ...olecules/ParametersTable/NoParameters.tsx
@@ -1,11 +1,11 @@
 import * as React from 'react'
 
-import { BORDERS, COLORS } from '../helix-design-system'
-import { SPACING, TYPOGRAPHY } from '../ui-style-constants/index'
-import { StyledText } from '../atoms/StyledText'
-import { Icon } from '../icons'
-import { Flex } from '../primitives'
-import { ALIGN_CENTER, DIRECTION_COLUMN } from '../styles'
+import { BORDERS, COLORS } from '../../helix-design-system'
+import { SPACING, TYPOGRAPHY } from '../../ui-style-constants/index'
+import { StyledText } from '../../atoms/StyledText'
+import { Icon } from '../../icons'
+import { Flex } from '../../primitives'
+import { ALIGN_CENTER, DIRECTION_COLUMN } from '../../styles'
 
 interface NoParametersProps {
   t?: any

diff --git a/...tersTable/__tests__/NoParameters.test.tsx → ...tersTable/__tests__/NoParameters.test.tsx b/...tersTable/__tests__/NoParameters.test.tsx → ...tersTable/__tests__/NoParameters.test.tsx
@@ -2,8 +2,8 @@ import * as React from 'react'
 import { screen } from '@testing-library/react'
 import { describe, it, expect } from 'vitest'
 
-import { renderWithProviders } from '../../testing/utils'
-import { BORDERS, COLORS } from '../../helix-design-system'
+import { renderWithProviders } from '../../../testing/utils'
+import { BORDERS, COLORS } from '../../../helix-design-system'
 import { NoParameters } from '../NoParameters'
 
 const render = (props: React.ComponentProps<typeof NoParameters>) => {

diff --git a/...sTable/__tests__/ParametersTable.test.tsx → ...sTable/__tests__/ParametersTable.test.tsx b/...sTable/__tests__/ParametersTable.test.tsx → ...sTable/__tests__/ParametersTable.test.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react'
-import { renderWithProviders } from '../../testing/utils'
+import { renderWithProviders } from '../../../testing/utils'
 import { describe, it, beforeEach } from 'vitest'
 import { screen } from '@testing-library/react'
 import { ParametersTable } from '../index'

diff --git a/components/src/parametersTable/index.tsx → ...s/src/molecules/ParametersTable/index.tsx b/components/src/parametersTable/index.tsx → ...s/src/molecules/ParametersTable/index.tsx
@@ -1,14 +1,12 @@
 import * as React from 'react'
 import styled from 'styled-components'
 import { formatRunTimeParameterValue } from '@opentrons/shared-data'
-import { BORDERS } from '../helix-design-system'
-import { SPACING, TYPOGRAPHY } from '../ui-style-constants/index'
-import { StyledText } from '../atoms/StyledText'
+import { BORDERS } from '../../helix-design-system'
+import { SPACING, TYPOGRAPHY } from '../../ui-style-constants/index'
+import { StyledText } from '../../atoms/StyledText'
 
 import type { RunTimeParameter } from '@opentrons/shared-data'
 
-export * from './NoParameters'
-
 interface ProtocolParameterItemsProps {
   runTimeParameters: RunTimeParameter[]
   t?: any

diff --git a/components/src/molecules/index.tsx b/components/src/molecules/index.tsx
@@ -1,2 +1,4 @@
 export * from './LocationIcon'
 export * from './RoundTab'
+export * from './ParametersTable'
+export * from './ParametersTable/NoParameters'