fetch on initial mount to reduce client latency

Opentrons · May 6, 2024 · 2703967 · 2703967
1 parent 30fddab
commit 2703967
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/src/resources/__tests__/useNotifyService.test.ts b/app/src/resources/__tests__/useNotifyService.test.ts
@@ -47,14 +47,15 @@ describe('useNotifyService', () => {
     vi.clearAllMocks()
   })
 
-  it('should trigger a subscribe action on a successful initial mount', () => {
+  it('should trigger an HTTP refetch and subscribe action on a successful initial mount', () => {
     renderHook(() =>
       useNotifyService({
         topic: MOCK_TOPIC,
         setRefetch: mockHTTPRefetch,
         options: MOCK_OPTIONS,
       } as any)
     )
+    expect(mockHTTPRefetch).toHaveBeenCalledWith('once')
     expect(mockDispatch).toHaveBeenCalledWith(
       notifySubscribeAction(MOCK_HOST_CONFIG.hostname, MOCK_TOPIC)
     )

diff --git a/app/src/resources/useNotifyService.ts b/app/src/resources/useNotifyService.ts
@@ -51,6 +51,8 @@ export function useNotifyService<TData, TError = Error>({
 
   React.useEffect(() => {
     if (shouldUseNotifications) {
+      // Always fetch on initial mount to keep latency as low as possible.
+      setRefetch('once')
       appShellListener({
         hostname,
         topic,