fix(app): fix stale failedCommand during Error Recovery

Opentrons · Aug 12, 2024 · 1463456 · 1463456
1 parent b99e7c2
commit 1463456
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/src/organisms/ErrorRecoveryFlows/hooks/useFailedLabwareUtils.ts b/app/src/organisms/ErrorRecoveryFlows/hooks/useFailedLabwareUtils.ts
@@ -62,7 +62,7 @@ export function useFailedLabwareUtils({
         failedCommandByRunRecord,
         runCommands,
       }),
-    [failedCommandByRunRecord?.error?.errorType, runCommands]
+    [failedCommandByRunRecord?.key, runCommands?.meta.totalLength]
   )
 
   const tipSelectionUtils = useTipSelectionUtils(recentRelevantFailedLabwareCmd)
@@ -74,12 +74,12 @@ export function useFailedLabwareUtils({
         recentRelevantFailedLabwareCmd,
         runRecord
       ),
-    [protocolAnalysis, recentRelevantFailedLabwareCmd, runRecord]
+    [protocolAnalysis?.id, recentRelevantFailedLabwareCmd?.key]
   )
 
   const failedLabware = React.useMemo(
     () => getFailedLabware(recentRelevantFailedLabwareCmd, runRecord),
-    [recentRelevantFailedLabwareCmd, runRecord]
+    [recentRelevantFailedLabwareCmd?.key]
   )
 
   const relevantWellName = getRelevantWellName(

diff --git a/app/src/organisms/ErrorRecoveryFlows/hooks/useRetainedFailedCommandBySource.ts b/app/src/organisms/ErrorRecoveryFlows/hooks/useRetainedFailedCommandBySource.ts
@@ -41,7 +41,11 @@ export function useRetainedFailedCommandBySource(
         })
       }
     }
-  }, [failedCommandByRunRecord?.key, protocolAnalysis?.id])
+  }, [
+    failedCommandByRunRecord?.key,
+    failedCommandByRunRecord?.error?.errorType,
+    protocolAnalysis?.id,
+  ])
 
   return retainedFailedCommand
 }