Skip to content

Commit

Permalink
refactor(app-shell-odd): Utilize robot-server unsubscribe flags (#14724)
Browse files Browse the repository at this point in the history
Closes EXEC-319

This is the app-shell-odd equivalent of the app-shell refactor, #14648. It's similar to the app-shell logic, but significantly simpler, since we don't have to manage multiple robots, worry about localhost port blocking, and multiple IPs per robot. The real change lies in the initial connect and final disconnect on app shutdown. Otherwise, the changes are primarily in the ConnectionStore. Because the app no longer utilizes unsubscribe actions in any capacity, we can safely remove those references.
  • Loading branch information
mjhuff authored and Carlos-fernandez committed Jun 3, 2024
1 parent 84b7e77 commit 044e7e0
Show file tree
Hide file tree
Showing 7 changed files with 48 additions and 455 deletions.
9 changes: 9 additions & 0 deletions app-shell-odd/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,13 @@ export const ROBOT_MASS_STORAGE_DEVICE_ENUMERATED: 'shell:ROBOT_MASS_STORAGE_DEV
export const NOTIFY_SUBSCRIBE: 'shell:NOTIFY_SUBSCRIBE' =
'shell:NOTIFY_SUBSCRIBE'
<<<<<<< HEAD
<<<<<<< HEAD
=======
export const NOTIFY_UNSUBSCRIBE: 'shell:NOTIFY_UNSUBSCRIBE' =
'shell:NOTIFY_UNSUBSCRIBE'
>>>>>>> 9359adf484 (chore(monorepo): migrate frontend bundling from webpack to vite (#14405))
=======
>>>>>>> 1ba616651c (refactor(app-shell-odd): Utilize robot-server unsubscribe flags (#14724))

// copy
// TODO(mc, 2020-05-11): i18n
Expand All @@ -256,10 +259,16 @@ export const HTTP_API_VERSION: 3 = 3
export const SEND_READY_STATUS: 'shell:SEND_READY_STATUS' =
'shell:SEND_READY_STATUS'
<<<<<<< HEAD
<<<<<<< HEAD
=======
>>>>>>> 1ba616651c (refactor(app-shell-odd): Utilize robot-server unsubscribe flags (#14724))

export const FAILURE_STATUSES = {
ECONNREFUSED: 'ECONNREFUSED',
ECONNFAILED: 'ECONNFAILED',
} as const
<<<<<<< HEAD
=======
>>>>>>> 9359adf484 (chore(monorepo): migrate frontend bundling from webpack to vite (#14405))
=======
>>>>>>> 1ba616651c (refactor(app-shell-odd): Utilize robot-server unsubscribe flags (#14724))
4 changes: 4 additions & 0 deletions app-shell-odd/src/notifications/deserialize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ import type {
import { FAILURE_STATUSES } from '../constants'

const VALID_NOTIFY_RESPONSES: [NotifyRefetchData, NotifyUnsubscribeData] = [
<<<<<<< HEAD
{ refetch: true },
=======
{ refetchUsingHTTP: true },
>>>>>>> 1ba616651c (refactor(app-shell-odd): Utilize robot-server unsubscribe flags (#14724))
{ unsubscribe: true },
]

Expand Down
Loading

0 comments on commit 044e7e0

Please sign in to comment.