Skip to content

feat(api, robot-server, app): Handle the Plate Reader lid while held by the gripper when the Estop is pressed. #45501

feat(api, robot-server, app): Handle the Plate Reader lid while held by the gripper when the Estop is pressed.

feat(api, robot-server, app): Handle the Plate Reader lid while held by the gripper when the Estop is pressed. #45501

Triggered via pull request October 22, 2024 23:17
Status Failure
Total duration 8m 10s
Artifacts

js-check.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 11 warnings
js checks: app/src/organisms/EmergencyStop/__tests__/EstopPressedModal.test.tsx#L25
Property 'isWaitingForPlateReaderLidPlacement' is missing in type '{ isEngaged: true; closeModal: Mock<[], void>; isWaitingForLogicalDisengage: false; setShouldSeeLogicalDisengage: Mock<[], void>; }' but required in type 'EstopPressedModalProps'.
js checks: app/src/organisms/EmergencyStop/__tests__/EstopPressedModal.test.tsx#L69
Property 'isWaitingForPlateReaderLidPlacement' is missing in type '{ isEngaged: true; closeModal: Mock<[], void>; isDismissedModal: false; setIsDismissedModal: Mock<[isDismissedModal: boolean], void>; isWaitingForLogicalDisengage: false; setShouldSeeLogicalDisengage: Mock<[], void>; }' but required in type 'EstopPressedModalProps'.
js checks
Process completed with exit code 2.
js checks: app/src/organisms/EmergencyStop/EstopTakeover.tsx#L32
'setisWaitingForPlateReaderLidPlacement' is assigned a value but never used
js checks: app/src/resources/modules/hooks/usePlacePlateReaderLid.ts#L3
All imports in the declaration are only used as types. Use `import type`
js checks: app/src/resources/modules/hooks/usePlacePlateReaderLid.ts#L9
All imports in the declaration are only used as types. Use `import type`
js checks: app/src/resources/modules/hooks/usePlacePlateReaderLid.ts#L16
An empty interface is equivalent to `{}`
js checks
Process completed with exit code 2.
js checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/github-script@v6, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
js checks: api-client/src/pipettes/types.ts#L62
A record is preferred over an index signature
js checks: api-client/src/pipettes/types.ts#L69
A record is preferred over an index signature
js checks: api-client/src/pipettes/types.ts#L77
A record is preferred over an index signature
js checks: api-client/src/pipettes/types.ts#L81
A record is preferred over an index signature
js checks: api-client/src/pipettes/types.ts#L90
A record is preferred over an index signature
js checks: api-client/src/types.ts#L14
A record is preferred over an index signature
js checks: app-shell-odd/src/actions.ts#L360
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L368
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L376
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L384
Expected property shorthand