layers/meta-opentrons: app uses sd_notify #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vegano1
reviewed
Mar 10, 2023
| Environment=@@application-environment@@ | ||
| ExecStart=/usr/bin/opentrons-robot-app.sh | ||
| RestartSec=1 | ||
| TimeoutStartSec=30 |
There was a problem hiding this comment.
is this enough startup time?
There was a problem hiding this comment.
don't really know, honestly. i'll be messing with it to verify.
It is now a notify service.
sfoster1
force-pushed
the
add-sd-notify-to-app
branch
from
03c04fe to
34e4098
Compare
sfoster1
added a commit
to Opentrons/opentrons
that referenced
this pull request
Mar 15, 2023
sd-notify is a utility for a program to communicate back to the systemd process manager that started it. It can be used in a variety of ways; the one that is most critical is to positively assert that it has started OK. Since this is a function call you can make any time you want to, this lets your program define when it has "started" on its own terms. The app, especially on the ODD, takes a long time to start - chrome takes a long time to start, and then we load up all our stuff. Currently, systemd considers us "started" as soon as the shell script that invokes chrome exits, which is long before anything useful is rendered. By making ourselves a notify service (in Opentrons/oe-core#63) and putting the notify at the time we receive the first ipc message, which indicates that the frontend is up, we can delay that "ready" status until we're actually rendering. This can then be used as a criterion in systemd to take down a loading screen. Closes RCORE-683
vegano1
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now a notify service.
Don't merge before Opentrons/opentrons#12266