Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentrons-ot3-image.bb: add chinese language support #174

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

vegano1
Copy link
Collaborator

@vegano1 vegano1 commented Oct 24, 2024

Overview

We are adding language localization support to the client, on the ODD we need to support the Chinese character set. This pull request adds support for that.

Closes: PLAT-573

Testing

  • Ensure there are no invalid characters when localization is enabled and Chinese is selected.

@vegano1 vegano1 requested a review from sfoster1 October 24, 2024 20:46
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about this lol

@vegano1
Copy link
Collaborator Author

vegano1 commented Nov 19, 2024

here we go

1000028020

@vegano1 vegano1 merged commit b4f209d into main Nov 19, 2024
3 checks passed
@vegano1 vegano1 deleted the PLAT-573-add-chinese-lang-support branch November 19, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants