Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes-bsp/u-boot: conditionally set can clock frequency based on SOM rev. #162

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

vegano1
Copy link
Collaborator

@vegano1 vegano1 commented Aug 15, 2024

Overview

The CAN clock frequency has changed from 20MHz to 40MHz as of Verdin iMX8M Mini Rev E, and since we have ordered a new batch of SOMs that will most likely be Rev E we need to support this change both at the factory to produce new robots but also for already deployed robots. This pull request updates the u-boot script to conditionally apply the "verdin-imx8mm_MCP2518_overlay.dtbo" overlay based on the SOM rev.

Closes: PLAT-464

Test Plan and Hands on Testing

  • Flash a SOM and make sure the device boots up
  • Flash a rev E SOM and make sure the can clock is set to 40Mhz.
  • Flash a rev D or lower SOM and make sure the can clock is set to 20Mhz.
  • Perform an OTA update on a rev E SOM and make sure the system boots and can clock stays at 40Mhz
  • Perform an OTA update on a < rev E SOM and make sure the system boots and CAN clock stays at 20Mhz
  • Make sure that the SOM can communicate with all CAN subsystems on the Flex (head, axis, gripper, etc)

Changelog

  • Conditionally apply the "verdin-imx8mm_MCP2518_overlay.dtbo" overlay for SOM revs lower than E.

Risk assessment

High, while this won't affect devices on the field, it will affect new SOMs flashed, so we need to ensure adequate testing.

@vegano1 vegano1 marked this pull request as ready for review August 15, 2024 19:46
@vegano1 vegano1 requested a review from sfoster1 August 15, 2024 19:49
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an issue in the skip logic that we can fix and improve the readability at the same time

@vegano1 vegano1 requested a review from sfoster1 August 20, 2024 11:58
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great to me!

@vegano1 vegano1 merged commit 9f0a08d into main Aug 23, 2024
3 checks passed
@vegano1 vegano1 deleted the PLAT-464-add-som-can-clock-change branch August 23, 2024 13:59
y3rsh added a commit that referenced this pull request Sep 30, 2024
feat(recipes-bsp/u-boot): cherry-pick #162 conditionally set can clock frequency based on SOM rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants