layers/meta-opentrons: binding for opentrons cli #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These bindings aren't installing from python properly, this will manually add them. Closes RESC-285
vegano1
reviewed
Jul 1, 2024
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env sh | |||
| export RUNNING_ON_VERDIN=1 | |||
| export OT_API_FF_enableOT3HardwareController="true" | |||
There was a problem hiding this comment.
should this be false for simulate?
There was a problem hiding this comment.
No, this is always true - this put it into "flex mode", it's not about controller vs simulator but about ot2 controller vs flex controller
|
Can you explain how this fixes the issue and then in what context these 2 files will be run? |
updated the pr description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit executable shell scripts for
opentrons_simulateandopentrons_execute.Normally, when you install python packages that have script entrypoints, the install process will generate the scripts and put them in the appropriate place. Here, we have a separate python environment in a special directory that the system doesn't know about - it's used by setting environment variables in systemd units. That means the installation won't work. So we do it ourself here.
Closes RESC-285