Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package/python-pandas: downgrade to 1.0.5 #222

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Feb 29, 2024

We have to pick a very specific pandas version to work properly on the new buildroot (much like we did with the old buildroot):

  • The version before the upgrade, 0.5.3, doesn't work with python 3.10's limited C interface (it uses an old enough cython that generated C does ++Py_REFCNT(obj) but >=3.10 doesn't have that macro resolving to an lvalue)
  • The absolute latest versions require a higher version of numpy than we provide
  • More recent versions than specifically the 1.0 series have something messed up in their cross-compilation and disagree with the numpy c library on the size of integers

The 1.0 series seems to work and 1.0.5 is the latest 1.0 so here we are.

Closes RQA-2413

This is the latest version that will work with our version of numpy.

Closes RQA-2413
@sfoster1 sfoster1 changed the title package/python-pandas: downgrade to 2.0.3 package/python-pandas: downgrade to 1.0.5 Mar 1, 2024
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the image built with this PR on my OT-2 and successfully used pandas in the python REPL.

# python
Python 3.10.8 (main, Mar  1 2024, 00:41:02) [GCC 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef90065c0eeb7 on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pandas as pd
>>> df = pd.DataFrame({'numbers': [1, 2, 3, 4, 5]})
>>>  df.sum()
  File "<stdin>", line 1
    df.sum()
IndentationError: unexpected indent
>>> df.sum()
numbers    15
dtype: int64
>>>

@sfoster1 sfoster1 merged commit 2edda12 into opentrons-develop Mar 1, 2024
3 checks passed
@sfoster1 sfoster1 deleted the rqa-2413-pandas-2-0-1 branch March 1, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants