Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new opencast api exceptions from API plugin #405

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

ferishili
Copy link
Contributor

This PR is to apply the changes introduced in Opencast-Moodle/moodle-tool_opencast#70

NOTE:

The branch-tool-plugin in the moodle-ci.yml file has to be reverted to main after merging this PR!

@ferishili ferishili requested a review from bluetom December 16, 2024 15:55
@ferishili ferishili self-assigned this Dec 16, 2024
@ferishili ferishili added the improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) label Dec 16, 2024
Copy link
Member

@bluetom bluetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR/code really only work with opencast version higher than 16.6?

@ferishili
Copy link
Contributor Author

ferishili commented Dec 19, 2024

Does this PR/code really only work with opencast version higher than 16.6?

It works only UP TO 16.x, and it does not work with 17.x
Actually, this applies not only to this PR but overall for this plugin if we use Opencast 17, the reason is that, the plugins are not yet compatible with Opencast 17:

Hope I could explain it clearly.

@bluetom bluetom added the ci Something which needs to be changed in CI after mering label Jan 13, 2025
@bluetom bluetom merged commit a68896a into Opencast-Moodle:main Jan 13, 2025
6 checks passed
@bluetom bluetom added the 4.5.3 label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something which needs to be changed in CI after mering improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants