Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Implement minor changes on change-admin command #51

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

spalladino
Copy link
Contributor

Builds on #47 adding suggestions by @facuspagnuolo.

facuspagnuolo
facuspagnuolo previously approved these changes Aug 29, 2018
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facuspagnuolo
Copy link
Contributor

The CI is failing, feel free to merge after fixing it 👍

@spalladino
Copy link
Contributor Author

@facuspagnuolo please re-review, as the new commit dismissed your review

Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facuspagnuolo facuspagnuolo merged commit 9bc9831 into next Aug 30, 2018
@facuspagnuolo facuspagnuolo deleted the changes/change-admin-command branch August 30, 2018 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants