This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Status command for multiple dependencies #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcarpanelli
previously requested changes
Aug 24, 2018
jbcarpanelli
suggested changes
Aug 24, 2018
packages/cli/src/scripts/status.js
Outdated
| @@ -81,44 +80,46 @@ async function contractsInfo(controller) { | |||
| .forEach(contractAlias => log.warn(`- ${contractAlias} will be removed on next push`)); | |||
| } | |||
|
|
|||
| async function stdlibInfo(networkFile) { | |||
| async function depsInfo(networkFile) { | |||
There was a problem hiding this comment.
As we are using dependencies/dependency everywhere, we should rename this to dependenciesInfo for consistency.
There was a problem hiding this comment.
@jcarpanelli updated!
packages/cli/src/scripts/status.js
Outdated
| @@ -10,7 +10,7 @@ export default async function status({ network, txParams = {}, networkFile = und | |||
|
|
|||
| if (!(await rootInfo(controller))) return; | |||
| if (!(await versionInfo(controller.networkFile))) return; | |||
| await stdlibInfo(controller.networkFile); | |||
| await depsInfo(controller.networkFile); | |||
jbcarpanelli
approved these changes
Aug 24, 2018
spalladino
added a commit
that referenced
this pull request
Sep 24, 2018
* Re-enable status command with multiple dependencies * Track both requirement and actual version on Dependency model * Rename depsInfo to dependenciesInfo in status script
spalladino
added a commit
that referenced
this pull request
Sep 24, 2018
* Re-enable status command with multiple dependencies * Track both requirement and actual version on Dependency model * Rename depsInfo to dependenciesInfo in status script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the
statuscommand that had been disabled for multiple dependencies on #17 .