Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

docs: remove basil and crafty demos #277

Merged
merged 1 commit into from
Oct 17, 2018
Merged

docs: remove basil and crafty demos #277

merged 1 commit into from
Oct 17, 2018

Conversation

come-maiz
Copy link
Contributor

@come-maiz come-maiz commented Oct 17, 2018

The demos are outdated. For 2.0, they should probably be replaced with
simpler examples.

Fixes: zeppelinos/zos-docs#96

[CI skip]

The demos are outdated. For 2.0, they should probably be replaced with
simpler examples.

Fixes: #96

[CI skip]
@facuspagnuolo facuspagnuolo self-assigned this Oct 17, 2018
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot find a reference in the code to make sure this change will be only applied for the documentation of the 2.0 version. Is that okey?

@come-maiz
Copy link
Contributor Author

Yes, I'm not deleting the files for the old versions, like: https://github.com/zeppelinos/zos/blob/master/packages/docs/docs/website/versioned_docs/version-1.0.0/basil.md
This will only apply when generating the new tag.

@facuspagnuolo facuspagnuolo merged commit 48c21b4 into OpenZeppelin:master Oct 17, 2018
facuspagnuolo pushed a commit that referenced this pull request Oct 23, 2018
* [CI skip] First draft of a new section describing the unstructured storage proxy pattern.

* [CI skip] Finished first draft of Proxy section.

* [CI skip] Merged some items in advanced.md to proxies.md

* [CI skip] Assimilated some of elopio's reviews

* [CI skip] Minor spelling fixes

* [CI skip] Added a few diagrams to the proxies section.

* Modified advanced section about json files to account for light mode.

* Removed (or names!)

* [CI skip] updated advanced section, jsons sub-section about the --full option.

* [CI skip] Typo fix explicitely > explicitly

* Update dependencies version on push (#279)

* Reupload contract if related lib has changed (#280)

* Add vouching kovan deploy

* Use version of dependency for identifying proxies in network json file (#281)

Changes both create and update commands to retrieve the package version
of either the project package or the dependency package when annotating
the proxy version in the network json file.

* Link command now successfully runs npm install again (#278)

* Check if project is published before freeze (#285)

* Check if project is published before freeze

* Check if package exists instead of if app exists

* docs: remove basil and crafty demos (#277)

The demos are outdated. For 2.0, they should probably be replaced with
simpler examples.

Fixes: #96

[CI skip]

* Stdlib/lib/dependency rename to package (#240)

* Rename stdlib/dependency to package

Fix unit tests

Modify option on integration test command call

Rename dependencies to packages in vouching

Change and revert some names
Change 'package' to 'dependencies' when necessary

* Implement suggestions from spalladino

* Fix storage layout parsing when there are complex types (#286)

Given a contract with a mapping or array (not struct), the check for
whether it contained structs or enums failed if there was no variable
with the same type as the value type of the mapping or array. For
instance, a contract with a variable of type `array(string)` and another
`string` would work, but a contract with just `array(string)` would
fail.

* Change status fix/fetch error message (#289)

* Preserve error stack trace when using ScriptError (#287)

* Update and unify package json files structures (#282)

* Check if package is frozen before uploading solidity libs (#284)

Previously the check was done only when uploading contracts, and caused
the solidity lib upload to fail with an EVM revert.

* Cleanup the READMEs (#276)

* Clean the main README

Fixes #232

* Added links to the blog and twitter

* Added links to the blog and twitter

* Update the docs README with suggestions by @facuspagnuolo

* Fix docs readme clone instructions

* Update to v2.0.0-rc.0

* Update CLI package lock

* Use latest versions of TPL-eth and OZ-eth (#295)

* Update to v2.0.0

* Fix vouching deployment script

* Update CLI package lock

* Update TPL-eth and OZ-eth to latest released versions

* Add zos files to vouching package files list

* Applied @facuspagnuolo's suggestion about publish

[CI skip]

* docs: restructure the docs webiste

Fixes: zeppelinos/zos-docs#94

[CI skip]

* Remove the duplicated proxies

* Fix the new in zOS 2 page.

[CI skip]

* [CI skip]

* correction for consistency

* fix small mistakes

* fix small mistakes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Basil and Crafty from 2.0 version
2 participants