Update forge-std, fix compiler warnings #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericglau
commented
Mar 15, 2024
•
ericglau
commented
- Updates forge-std to v1.8.0, restrict state mutability of some functions to avoid compiler warnings.
- Note: This is a breaking change, requiring the user's project to use forge-std v1.8.0 or later.
- One of the test contracts in this project has a selfdestruct, which we use as part of the upgrade safety validation tests. However, this gives a compiler warning since selfdestruct is deprecated. This PR changes this tescase to use a delegatecall instead.
ericglau
changed the title
ericglau
changed the title
ericglau
changed the title
ernestognw
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.