Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to get approval process information from Defender #23

Merged
merged 21 commits into from
Feb 20, 2024

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Feb 13, 2024

Fixes #22

Prerequisites:

  1. Add Defender.proposeUpgrade function #21
  2. Add commands to get approval process info, rename options defender-deploy-client-cli#4

Only commits newer than f086c8c need to be reviewed. The previous commits are from #21 since this PR builds upon that.

Ready for review, but leaving as draft until the two prerequisites above are available.

@ericglau ericglau marked this pull request as ready for review February 13, 2024 21:31
@ericglau ericglau requested a review from a team February 13, 2024 21:31
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ericglau ericglau merged commit f38a460 into OpenZeppelin:main Feb 20, 2024
3 checks passed
@ericglau ericglau deleted the approvalprocess branch February 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functions to get approval processes from Defender
2 participants