Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing apostrophe owner s to owner's #5462

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

XxAlex74xX
Copy link

owner s - owner's

fix typos

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 9b55fd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arr00
Copy link
Contributor

arr00 commented Jan 27, 2025

In most cases changed here, the current implementation is actually aligned with our style requirements--just the parameter being mentioned should be in the code block. The apostrophe s, when necessary, should be out of the code block. There are places where the apostrophe is missing. Feel free to change the PR to fix those occurrences.

@XxAlex74xX
Copy link
Author

@arr00 thanks ! done ?

@arr00 arr00 changed the title chore: fix owner's to owner's Add missing apostrophie owner s to owner's Jan 28, 2025
@arr00 arr00 changed the base branch from master to typo-fixes January 28, 2025 16:41
@arr00 arr00 changed the title Add missing apostrophie owner s to owner's Add missing apostrophe owner s to owner's Jan 28, 2025
@arr00 arr00 merged commit 8e91d91 into OpenZeppelin:typo-fixes Jan 28, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants