-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky timestamp tests #4046
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome !
The test suite is going a lot slower than before. Is it due to this PR? |
Test suite took twice the time it usually takes. I'm disabling gas reporting to see if it helps. |
gas report definitelly making all tests WAY slower |
9283c05
to
49ccb68
Compare
|
It made sens that d79c2ec would fix the issue of flaky timestamps, but I'm not sure how we expect the current version of the PR to do anything since the behavior for timestamps in |
@Amxx I'm just trying things out to debug the test time degradation. |
They are due to an how OpenZeppelin Test Helpers implements
time.increaseTo
. We should prefer Hardhat's own network helpers (eventually we should migrate the rest of the test suite).I also included a small refactor of
.then
in the Governor helper.Fixes #4049