Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Context abstract #2229

Merged
merged 1 commit into from
May 8, 2020
Merged

Make Context abstract #2229

merged 1 commit into from
May 8, 2020

Conversation

frangio
Copy link
Contributor

@frangio frangio commented May 8, 2020

Other instances where we could do the same if we moved state variable initialization outside of the constructor:

constructor () internal {
// Storing an initial non-zero value makes deployment a bit more
// expensive, but in exchange the refund on every call to nonReentrant
// will be lower in amount. Since refunds are capped to a percetange of
// the total transaction's gas, it is best to keep them low in cases
// like this one, to increase the likelihood of the full refund coming
// into effect.
_notEntered = true;
}

constructor () internal {
_paused = false;
}

@frangio frangio requested a review from nventuro May 8, 2020 14:34
@nventuro
Copy link
Contributor

nventuro commented May 8, 2020

This is related to ethereum/solidity#8162, abstract should be required.

@nventuro nventuro merged commit 0c7b2ec into master May 8, 2020
@nventuro nventuro deleted the frangio-patch-1 branch May 8, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants