Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve revert reason #1727 #2018

Merged
merged 24 commits into from
Jan 23, 2020
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
839b6bf
adding mock contacts, test code
alant Dec 8, 2019
bcb3125
adding changes to ERC721.sol per @frangio's comments on original PR #…
alant Dec 8, 2019
2ee16ec
fix solhint warnings
alant Dec 8, 2019
027822d
Update contracts/token/ERC721/ERC721.sol
alant Dec 10, 2019
07dcbd3
same revert wording per @frangio's review suggestion
alant Dec 10, 2019
1755395
Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/…
alant Dec 10, 2019
be4d51d
per @frangio's feedback, changing the inline assembly to accomplish: …
alant Dec 10, 2019
f0a90f6
change revert msg assembly per PR comment by @frangio
alant Dec 11, 2019
ab1fb60
unify revert msg in test code
alant Dec 11, 2019
59cba42
Merge branch 'master' into fix/improve-revert-reason-#1727
alant Dec 11, 2019
cd436a6
fix some failed tests, wording change
alant Dec 12, 2019
ee84cda
Update contracts/token/ERC721/ERC721.sol
alant Dec 13, 2019
829032d
Update contracts/token/ERC721/ERC721.sol
alant Dec 13, 2019
f5a6a95
Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/…
alant Dec 13, 2019
1162b59
fix test case, revert without reason
alant Dec 24, 2019
6aec945
fix 'ERC721ReceiverRevertsMock: Transaction rejected by receiver'
alant Jan 7, 2020
604f88b
Merge branch 'master' into fix/improve-revert-reason-#1727
alant Jan 7, 2020
9668a49
style change per review by @frangio
alant Jan 14, 2020
cf5c2b8
Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/…
alant Jan 14, 2020
f279bec
fix revert reason forwarding
frangio Jan 14, 2020
6f33362
remove duplicate contracts/mocks/ERC721ReceiverRevertsMock.sol per re…
alant Jan 15, 2020
4c2930d
Add changelog entry
nventuro Jan 23, 2020
2538e97
Fix tests
nventuro Jan 23, 2020
f3e382a
Make tests more clear
nventuro Jan 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into fix/improve-revert-reason-#1727
alant authored Dec 11, 2019
commit 59cba4211bf9619e71a93a559a0c329a69cb7d33

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.