Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PullPayment docs #1965

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Conversation

nventuro
Copy link
Contributor

These were rather bare, and the recent discussion around EIP1884 makes them more relevant than ever.

@nventuro nventuro added the documentation Inline comments, guides, and examples. label Oct 24, 2019
@nventuro nventuro requested a review from frangio October 24, 2019 21:10
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

contracts/payment/PullPayment.sol Outdated Show resolved Hide resolved
@nventuro nventuro merged commit 9e19d90 into OpenZeppelin:master Oct 24, 2019
@nventuro nventuro deleted the pull-payment-docs branch October 24, 2019 22:04
frangio pushed a commit that referenced this pull request Oct 29, 2019
* Improve PullPayment docs

* Reword escrow note

* Update contracts/payment/PullPayment.sol

Co-Authored-By: Francisco Giordano <[email protected]>
(cherry picked from commit 9e19d90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inline comments, guides, and examples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants