feat: use require in SafeMath #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Aug 10, 2018
test/math/SafeMath.test.js
Outdated
| @@ -22,11 +22,11 @@ contract('SafeMath', () => { | |||
| result.should.be.bignumber.equal(a.plus(b)); | |||
| }); | |||
|
|
|||
| it('throws an error on addition overflow', async function () { | |||
| it('throws an revert error on addition overflow', async function () { | |||
There was a problem hiding this comment.
nit: throws a revert :) (on this and all other it blocks)
nventuro
added
kind:improvement
contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1121 and #1120, changes
SafeMathto usereverts instead ofasserts.Fixes #1120.
npm run lint:all:fix).