Skip to content

Commit

Permalink
Remove redundant require statements (#1409)
Browse files Browse the repository at this point in the history
* Remove redundant require statements

Now that SafeMath uses require, the require statements are redundant. They were also previously inconsistent because they were only included in some functions, but not others

* Update ERC20.sol
  • Loading branch information
Brendan Chou authored and nventuro committed Nov 2, 2018
1 parent f72c79d commit 6363a77
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions contracts/token/ERC20/ERC20.sol
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ contract ERC20 is IERC20 {
public
returns (bool)
{
require(value <= _allowed[from][msg.sender]);

_allowed[from][msg.sender] = _allowed[from][msg.sender].sub(value);
_transfer(from, to, value);
return true;
Expand Down Expand Up @@ -155,7 +153,6 @@ contract ERC20 is IERC20 {
* @param value The amount to be transferred.
*/
function _transfer(address from, address to, uint256 value) internal {
require(value <= _balances[from]);
require(to != address(0));

_balances[from] = _balances[from].sub(value);
Expand All @@ -172,6 +169,7 @@ contract ERC20 is IERC20 {
*/
function _mint(address account, uint256 value) internal {
require(account != address(0));

_totalSupply = _totalSupply.add(value);
_balances[account] = _balances[account].add(value);
emit Transfer(address(0), account, value);
Expand All @@ -185,7 +183,6 @@ contract ERC20 is IERC20 {
*/
function _burn(address account, uint256 value) internal {
require(account != address(0));
require(value <= _balances[account]);

_totalSupply = _totalSupply.sub(value);
_balances[account] = _balances[account].sub(value);
Expand Down

0 comments on commit 6363a77

Please sign in to comment.