Html to wml enhancements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaltDaniels
reviewed
Mar 1, 2019
| @@ -2829,9 +2829,9 @@ private static XElement[] GetSpacingProperties(XElement paragraph, HtmlToWmlConv | |||
| // todo should check based on display property | |||
| bool numItem = paragraph.Name == XhtmlNoNamespace.li; | |||
|
|
|||
| if (numItem && marginTopProperty.IsAuto) | |||
| if (numItem && marginTopProperty != null && marginTopProperty.IsAuto) | |||
There was a problem hiding this comment.
Why not just use
`if (numItem && marginTopProperty?.IsAuto)'
There was a problem hiding this comment.
The reason is that numItem is 'bool', but marginTopProperty?.IsAuto is 'bool?' , so '&&' operator cannot be applied to 'bool' and 'bool?'.
Thank you for your review!
There was a problem hiding this comment.
if (numItem && marginTopProperty?.IsAuto == true)
ZonerZoner
suggested changes
Apr 23, 2020
| beforeAutospacing = "1"; | ||
| if (numItem && marginBottomProperty.IsAuto) | ||
| if (numItem && marginTopProperty != null && marginBottomProperty.IsAuto) |
There was a problem hiding this comment.
I think this should be marginBottomProperty != null (copy/paste issue I guess)
There was a problem hiding this comment.
if (numItem && marginBottomProperty?.IsAuto == true)
huan086
pushed a commit
to huan086/Open-Xml-PowerTools
that referenced
this pull request
Sep 17, 2024
V next -> master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.