Add Config handling for language modules #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in TranslationFactory inig Add default config to base Language classes
Codecov Report
@@ Coverage Diff @@
## dev #74 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 40
Lines ? 2661
Branches ? 0
=====================================
Hits ? 0
Misses ? 2661
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JarbasAl
reviewed
Aug 26, 2022
JarbasAl
reviewed
Aug 26, 2022
JarbasAl
reviewed
Aug 27, 2022
JarbasAl
reviewed
Aug 27, 2022
|
couple nitpicks that can be ignored, this looks good and much cleaner! |
JarbasAl
reviewed
Aug 29, 2022
JarbasAl
requested changes
Aug 29, 2022
JarbasAl
reviewed
Sep 16, 2022
| """ | ||
| config = config or Configuration() | ||
| lang = config.get('lang') or Configuration().get('lang') | ||
| config = (config.get('intentBox', {}).get(section) or config.get(section) |
There was a problem hiding this comment.
should this be behind some other check? will merge for now but we should revisit since this allows any config to live under intentBox section and we likely want to throw an error in that case
JarbasAl
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Language factory to pass module config
Fix typo in TranslationFactory inig
Add default config to base Language classes