Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available_languages properties to Language Detector and Translator plugins #73

Merged
merged 3 commits into from
Aug 26, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions ovos_plugin_manager/templates/language.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@ def detect(self, text):
def detect_probs(self, text):
return {self.detect(text): 1}

@property
def available_languages(self) -> set:
"""
Return languages supported by this detector implementation in this state.
This should be a set of languages this detector is capable of recognizing.
This property should be overridden by the derived class to advertise
what languages that engine supports.
JarbasAl marked this conversation as resolved.
Show resolved Hide resolved
Returns:
set: supported languages
"""
return set()


class LanguageTranslator:
def __init__(self, config=None):
Expand Down Expand Up @@ -46,3 +58,26 @@ def translate_list(self, data, lang_tgt, lang_src="en"):
elif isinstance(v, list):
data[idx] = self.translate_list(v, lang_tgt, lang_src)
return data

@property
def available_languages(self) -> set:
"""
Return languages supported by this translator implementation in this state.
Any language in this set should be translatable to any other language in the set.
This property should be overridden by the derived class to advertise
what languages that engine supports.
NeonDaniel marked this conversation as resolved.
Show resolved Hide resolved
Returns:
set: supported languages
"""
return set()

def supported_translations(self, source_lang: str = None) -> set:
"""
Return valid target languages we can translate `source_lang` to.
This method should be overridden by the derived class.
Args:
source_lang: ISO 639-1 source language code
Returns:
set of ISO 639-1 languages the source language can be translated to
"""
return self.available_languages