Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ovos_config_pkg #70

Merged
merged 1 commit into from
Jul 29, 2022
Merged

refactor/ovos_config_pkg #70

merged 1 commit into from
Jul 29, 2022

Conversation

NeonJarbas
Copy link
Contributor

update config loading to use Configuration() directly instead of the old method read_mycroft_config from ovos_utils

improve logs and exception handling when loading TTS/WW plugins

update config loading to use latest ovos_config

improve logs and exception handling when loading plugins
@JarbasAl JarbasAl requested a review from NeonDaniel July 29, 2022 09:22
@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@d6994a4). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #70   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      39           
  Lines          ?    2283           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    2283           
  Partials       ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6994a4...b0408a8. Read the comment docs.

@JarbasAl JarbasAl merged commit 1a038e1 into OpenVoiceOS:dev Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants