Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/tokenizer_plugin #51

Merged
merged 2 commits into from
Mar 30, 2022
Merged

feat/tokenizer_plugin #51

merged 2 commits into from
Mar 30, 2022

Conversation

NeonJarbas
Copy link
Contributor

@NeonJarbas NeonJarbas commented Mar 30, 2022 •
edited
Loading

@JarbasAl JarbasAl added the enhancement New feature or request label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@6eea829). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #51   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      34           
  Lines          ?    2097           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    2097           
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eea829...16836b7. Read the comment docs.

@JarbasAl JarbasAl requested a review from NeonDaniel March 30, 2022 17:42
@JarbasAl JarbasAl merged commit 2afb014 into OpenVoiceOS:dev Mar 30, 2022
@NeonJarbas NeonJarbas mentioned this pull request Mar 30, 2022
Merged
NeonDaniel
NeonDaniel reviewed Mar 30, 2022
View reviewed changes
ovos_plugin_manager/templates/tokenization.py
lang = msg.data.get("lang")
return lang or "en-us"

def span_tokenize(self, text, lang=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider docstrings to document the difference between tokenize and span_tokenize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeonJarbas @NeonDaniel @JarbasAl