Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multiple playback thread start #45

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix/multiple playback thread start #45

merged 1 commit into from
Mar 18, 2022

Conversation

NeonJarbas
Copy link
Contributor

exception calling callback for <Future at 0x7f8d5527c0 state=finished raised RuntimeError>
Traceback (most recent call last):
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 328, in _invoke_callbacks
    callback(self)
  File "/home/mycroft/.local/lib/python3.8/site-packages/pyee/_executor.py", line 56, in _callback
    self.emit('error', exc)
  File "/home/mycroft/.local/lib/python3.8/site-packages/pyee/_base.py", line 116, in emit
    self._emit_handle_potential_error(event, args[0] if args else None)
  File "/home/mycroft/.local/lib/python3.8/site-packages/pyee/_base.py", line 86, in _emit_handle_potential_error
    raise error
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/mycroft/.local/lib/python3.8/site-packages/mycroft/audio/speech.py", line 63, in handle_speak
    mute_and_speak(utterance, ident, listen)
  File "/home/mycroft/.local/lib/python3.8/site-packages/mycroft/audio/speech.py", line 89, in mute_and_speak
    tts.init(bus)
  File "/home/mycroft/.local/lib/python3.8/site-packages/ovos_plugin_manager/templates/tts.py", line 445, in init
    TTS.playback.start()
  File "/usr/lib/python3.8/threading.py", line 848, in start
    raise RuntimeError("threads can only be started once")
RuntimeError: threads can only be started once

@JarbasAl JarbasAl added the bug Something isn't working label Mar 18, 2022
@JarbasAl JarbasAl requested review from j1nx and NeonDaniel March 18, 2022 16:05
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@4f81783). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1b72791 differs from pull request most recent head 545ba60. Consider uploading reports for the commit 545ba60 to get more accurate results

@@          Coverage Diff          @@
##             dev     #45   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      28           
  Lines          ?    1788           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    1788           
  Partials       ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f81783...545ba60. Read the comment docs.

@JarbasAl JarbasAl merged commit 9b1db59 into OpenVoiceOS:dev Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants