tts lang #3
Merged
tts lang #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
approved these changes
Sep 7, 2021
| @@ -381,7 +382,7 @@ def _preprocess_sentence(self, sentence): | |||
| """ | |||
| return [sentence] | |||
|
|
|||
| def execute(self, sentence, ident=None, listen=False): | |||
| def execute(self, sentence, ident=None, listen=False, **kwargs): | |||
There was a problem hiding this comment.
Should expected/supported kwargs be added to the docstring here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support the lang parameter when running under HolmesV derivatives, those always go through the
executemethodalso ensures mycroft-style plugins that don't accept lang work
it should not impact standalone usage of plugins (calling
get_ttsdirectly), those are expected to handle a missing/None lang parameter, its the downstream's code responsibility to ensure things work if using plugins this way, eg, hivemind-voice-satellite passes this lang param on its own accord and skips usage ofexecute, if it loads a plugin that does not accept lang that is out of scope for OPMthis should bring support for neon-core and hivemind