fix:phal config loading

[JarbasAl]

Summary by CodeRabbit

• Bug Fixes

  • Improved the configuration retrieval process in the PHALPlugin, enhancing stability and performance.

• Chores

  • Removed unnecessary import for the get_plugin_config utility, streamlining the code.

[coderabbitai]

Walkthrough

The changes involve modifications to the PHALPlugin class in the ovos_plugin_manager/templates/phal.py file. The configuration retrieval logic in the __init__ method has been updated to replace the utility function get_plugin_config with a direct access method to the configuration dictionary. This simplifies the way plugin configurations are fetched. Additionally, the import statement for get_plugin_config has been removed, reflecting its obsolescence.

Changes

File Path	Change Summary
ovos_plugin_manager/templates/phal.py	Updated self.config retrieval in PHALPlugin from get_plugin_config to direct access method. Removed import of get_plugin_config.

Poem

In the land of code where plugins play,
A rabbit hops, and changes sway.
With simpler paths, the config's found,
No more utilities, just joy abound!
Hooray for the tweaks, let’s dance and cheer,
For every small change brings us near! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d2d7646 and df758c0.

📒 Files selected for processing (1)

• ovos_plugin_manager/templates/phal.py (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

ovos_plugin_manager/templates/phal.py (1)

38-38: Simplified configuration retrieval looks good!

The change from using get_plugin_config to direct dictionary access is a good simplification. It reduces dependencies and potentially improves performance slightly. The use of nested .get() calls with default empty dictionaries is a safe approach to handle potentially missing keys.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.