Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAD module tests with bugfixes and doc updates #156

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

NeonDaniel
Copy link
Member

Fixes default config behavior to ensure dummy plugin is loaded
Includes fixes to ensure parsed configuration matches plugin expectations
Fixed vad vs VAD typos in documentation

@NeonDaniel NeonDaniel marked this pull request as ready for review May 22, 2023 23:32
@NeonDaniel NeonDaniel requested a review from a team May 22, 2023 23:32
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@ff64e30). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #156   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      55           
  Lines          ?    3933           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3933           
  Partials       ?       0           

@NeonDaniel NeonDaniel requested a review from JarbasAl May 23, 2023 21:14
Explicitly raise exceptions if VAD module isn't configured
@JarbasAl JarbasAl merged commit 8d3749b into dev May 24, 2023
@JarbasAl JarbasAl deleted the FIX_DummyVADPlugin branch May 24, 2023 00:10
@github-actions github-actions bot mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants