Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hotword Plugin Load Compat #153

Merged
merged 4 commits into from
May 18, 2023
Merged

Fix Hotword Plugin Load Compat #153

merged 4 commits into from
May 18, 2023

Conversation

NeonDaniel
Copy link
Member

Fix WakeWordFactory method internal references to resolve configuration handling bug
Document and add unit tests for OVOSWakeWordFactory

@NeonDaniel NeonDaniel requested a review from a team May 18, 2023 02:12
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@d54f382). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #153   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      55           
  Lines          ?    3923           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3923           
  Partials       ?       0           

@JarbasAl JarbasAl added the bug Something isn't working label May 18, 2023
@JarbasAl JarbasAl merged commit 39cb59e into dev May 18, 2023
@JarbasAl JarbasAl deleted the FIX_HotwordPlugins branch May 18, 2023 02:18
@github-actions github-actions bot mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants