-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update load exception logging #128
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #128 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 47
Lines ? 3286
Branches ? 0
=====================================
Hits ? 0
Misses ? 3286
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed but not tested
# if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old test code; I commented out when troubleshooting extra OCP init but it wasn't related. I can replace this if wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure it wasn’t functional code deactivated by mistake. Only reason to remove it this instant would be if you think it’ll be hard to spot in a cleanup pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, still not tested. Looks like boilerplate changes and a linter pass, nothing for CI to miss.
Ensure any plugin load exceptions print the entire exception instead of just a generic message for debugging