Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load exception logging #128

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Update load exception logging #128

merged 2 commits into from
Mar 1, 2023

Conversation

NeonDaniel
Copy link
Member

Ensure any plugin load exceptions print the entire exception instead of just a generic message for debugging

@NeonDaniel NeonDaniel requested a review from a team February 28, 2023 23:52
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@696231c). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #128   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      47           
  Lines          ?    3286           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3286           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ChanceNCounter ChanceNCounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed but not tested

# if __name__ == "__main__":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s going on here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old test code; I commented out when troubleshooting extra OCP init but it wasn't related. I can replace this if wanted

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure it wasn’t functional code deactivated by mistake. Only reason to remove it this instant would be if you think it’ll be hard to spot in a cleanup pass.

@ChanceNCounter ChanceNCounter self-requested a review March 1, 2023 18:31
Copy link

@ChanceNCounter ChanceNCounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, still not tested. Looks like boilerplate changes and a linter pass, nothing for CI to miss.

@NeonDaniel NeonDaniel merged commit 4f3849a into dev Mar 1, 2023
@NeonDaniel NeonDaniel deleted the LOG_UpdateErrorLogging branch March 1, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants