Format uk

[NeonMariia]

No description provided.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (dev@a4697e2). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #50   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      69           
  Lines          ?   18251           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?   18251           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[NeonDaniel]

@NeonMariia I think these are the users you said could review this: @robinhad @VicGrygorchyk . I can't request reviews from non-maintainers, but anyone should be able to leave a review with comments.

If these changes look good to a native speaker, they are already passing unit tests so one of the maintainers here can merge it

[robinhad]

Hi @NeonDaniel !
Thanks for adding me to this pull request. I have a dataset with cases for normalization, need some time to prepare it for evaluation and I'll get back to you.

[NeonDaniel]

Associated PR for parsing: #51

[JarbasAl]

as mention in companion PR #51

we just had a stable release and are back in alpha versions, I am ok with merging this as is and fix any issues in follow up PRs. This is great work and I'd like to get it in the wild!

Only see some debug prints to remove and maybe a rebase, there seems to be some duplicated code too between this and #51

[robinhad]

Hi! Added a couple of comments with suggestion how to improve, overall looks great!

[NeonDaniel]

It looks like there are a few unaddressed comments, but n approving review from @robinhad. Should there be an issue to include those changes later, or are then intentionally not included?

I don't necessarily want to hold the PR for minor improvements but if they're valid, creating an issue will make sure we don't lose track of them.

[robinhad]

Hi @NeonDaniel, they are valid, please include them in separate issue as improvements

[NeonDaniel]

Hi @NeonDaniel, they are valid, please include them in separate issue as improvements

Looks like another PR got most of them so I'll open an issue for the last couple before merging this one.

[emphasize]

leftover file

[ChanceNCounter]

that whole directory, on review

[ChanceNCounter]

On final review before merging, there only turned out to be one unresolved addition to the resource files, so I just threw that in. I also found one more stray tempfile directory, so I've removed that and re-requested @emphasize's review so as not to self-merge. Should be good to go.

[emphasize]

All unittests are commented out, i don't think this is wanted