Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the advertised audio device and sample rate with the audio test. #265

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Actually use the advertised audio device and sample rate with the audio test. #265

merged 3 commits into from
Jan 25, 2023

Conversation

gmsoft-tuxicoman
Copy link

The audio test display which device it is about to use but then doesn't provide it to the underlying API.

@gmsoft-tuxicoman gmsoft-tuxicoman changed the title Actually use the advertised device. Actually use the advertised audio device with the audio test. Jan 25, 2023
@gmsoft-tuxicoman gmsoft-tuxicoman changed the title Actually use the advertised audio device with the audio test. Actually use the advertised audio device and sample rate with the audio test. Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #265 (1681ab7) into dev (6ceb058) will increase coverage by 2.61%.
The diff coverage is 43.45%.

❗ Current head 1681ab7 differs from pull request most recent head 0fd4ba8. Consider uploading reports for the commit 0fd4ba8 to get more accurate results

@@            Coverage Diff             @@
##              dev     #265      +/-   ##
==========================================
+ Coverage   50.35%   52.97%   +2.61%     
==========================================
  Files         119      156      +37     
  Lines       10077     8027    -2050     
==========================================
- Hits         5074     4252     -822     
+ Misses       5003     3775    -1228     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit 1a67a4b into OpenVoiceOS:dev Jan 25, 2023
@JarbasAl JarbasAl mentioned this pull request Jan 26, 2023
23 tasks
@JarbasAl JarbasAl added this to the 0.0.6 milestone Jan 26, 2023
@JarbasAl JarbasAl added the bug Something isn't working label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants