Prevent exceptions if a user doesn't reply to an ask_yesno prompt
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #252 +/- ##
==========================================
+ Coverage 50.35% 54.88% +4.53%
==========================================
Files 119 156 +37
Lines 10077 9357 -720
==========================================
+ Hits 5074 5136 +62
+ Misses 5003 4221 -782
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NeonDaniel
force-pushed
the
FIX_YesOrNoResponse
branch
from
26fa011 to
48013e9
Compare
j1nx
approved these changes
Jan 17, 2023
NeonDaniel
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
Jan 17, 2023
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
Jan 18, 2023
* feat/SkillNetworkRequirements * rename args for clariy * classproperty * refactor the old patches module deduplicate code between ovos-core and workshop support get_response refactor * fix __new__ * refactor/standalone_skill_class to avoid mycroft module import mess * temp update workflows for unittests from open PRs * fix setup.py * . * . * metaclass for instanchecks * metaclass for instanchecks * get_response * fix imports * require ovos_lf * move killable_intents support to base class * inject skill features into vanila mycroft * keep enums together * fix metaclass * tests * tests * tests * mycroft-core compat * mycroft-core compat * mycroft-core compat * bump outils * bump outils * make some props private * Patch backwards compat. (#37) * Cleanup logging for backwards-compat init * Add flag to disable settings manager Default AbstractApp base class to not use settings manager * Pass `enable_settings_manager` kwarg from OVOSAbstractApplication init * Fix settings manager init flag with unit tests * Resolve bad import Cleanup logging in init * Resolve editor import errors * Add `bus` setter for backwards-compat with unit test * Cleanup import logic * Skip SettingsManager test under mycroft-core * Address PR feedback * Annotate future test dependency change * Fix comment formatting * Port changes from #35 to base MycroftSkill class * OVOSAbstractApplication backwards-compat. (#38) * Handle passed App configuration with unit tests * Handle passed `gui` arg with unit test * Override settings path for AbstractApplications Mark passed settings init as deprecated * Add settings test cases * Port OpenVoiceOS/ovos-core#252 * Resolve Automated Test Failures (#39) * Ignore setuptools bug failing pip-audit * Improve tests to test expected behavior and not test quirks of out-of-scope implementations * Patch BaseSkill methods to resolve ovos-core unit test failures (#40) * Fix typo in port of #37 * Update `is_ovos` references to `ovos_utils` * Remove unused `util` module * Update `is_ovos` references * Fix recursive call in instancecheck * Fix isinstance checks * Add FallbackSkill test case * Port tests from ovos-core that apply to relocated code (#41) * Port core skill tests (#42) * Add `adapt` to test requirements * Resolve broken import * Update adapt test dependency * Fix test relative import error * Add resources for unit tests Skip failing test * Fix typo in skipped test Co-authored-by: Daniel McKnight <[email protected]> Co-authored-by: Daniel McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.