Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/skill class from workshop #246

Merged
merged 15 commits into from
Jan 20, 2023
Merged

Refactor/skill class from workshop #246

merged 15 commits into from
Jan 20, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 16, 2022 •
edited by NeonDaniel
Loading

  • companion to refactor the old patches module OVOS-workshop#34

  • needs sync utils with core ovos-utils#89

  • move MycroftSkill to ovos_workshop

    • this reduces a lot of import issues
    • removes most duplicated code in OVOSAbstractApp
    • easier to maintain backwards compat with MycroftSkill class
      -.easier to add new public apis to OVOSSkill

  • sync duplicated utils from ovos_utils and import from there

  • move filesystem to workshop, these are also helpful in other ovos packages

@JarbasAl JarbasAl added the refactor code refactor without functional changes label Dec 16, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel December 16, 2022 01:59
@JarbasAl JarbasAl force-pushed the refactor/skill_class_from_workshop branch from a07162b to 5b01cca Compare December 16, 2022 04:32
@JarbasAl JarbasAl mentioned this pull request Jan 10, 2023
Closed
23 tasks
@NeonDaniel NeonDaniel force-pushed the refactor/skill_class_from_workshop branch 2 times, most recently from 601e637 to 2cf70dd Compare January 17, 2023 22:38
@NeonDaniel NeonDaniel mentioned this pull request Jan 18, 2023
Merged
@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #246 (9c5ae4d) into dev (6ceb058) will increase coverage by 2.65%.
The diff coverage is 43.45%.

@@            Coverage Diff             @@
##              dev     #246      +/-   ##
==========================================
+ Coverage   50.35%   53.01%   +2.65%     
==========================================
  Files         119      156      +37     
  Lines       10077     8021    -2056     
==========================================
- Hits         5074     4252     -822     
+ Misses       5003     3769    -1234
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JarbasAl and others added 11 commits January 18, 2023 16:55
@JarbasAl @NeonDaniel
bump LF
4e8f2d3 
fix imports

event + intnet interfaces from outils

.

.

temp update workflows for unittests from open PRs

refactor/bump+dedup code from workshop
@JarbasAl @NeonDaniel
keep enums together
13a0fc9
@JarbasAl @NeonDaniel
fix imports
41d2507
@JarbasAl @NeonDaniel
fix tests
80a6f90
@JarbasAl @NeonDaniel
audio unittests
364519a
@JarbasAl @NeonDaniel
bump outils
8259fc7
@JarbasAl @NeonDaniel
bump outils
e257d0e
@NeonDaniel
Patch is_fully_initialized property reference (#254)
e974574
@NeonDaniel
Update overrides in tests for updated BaseSkill compat. (#255)
b30f3cf 
Added some test cases to debug failures
@NeonDaniel
Update tests to support workshop refactor (#256)
131715a 
* Update tests to support workshop refactor

* Update tests to support workshop refactor
@NeonDaniel
Update workshop and ocp plugin dependencies
f3b0958
@NeonDaniel NeonDaniel marked this pull request as ready for review January 19, 2023 00:59
@NeonDaniel NeonDaniel force-pushed the refactor/skill_class_from_workshop branch from 8ead6c3 to eb8f6ab Compare January 19, 2023 17:19
NeonDaniel
NeonDaniel reviewed Jan 20, 2023
View reviewed changes
mycroft/deprecated/skills/__init__.py Outdated Show resolved Hide resolved
.github/workflows/unit_tests.yml Outdated Show resolved Hide resolved
@NeonDaniel NeonDaniel marked this pull request as draft January 20, 2023 00:42
@NeonDaniel NeonDaniel marked this pull request as ready for review January 20, 2023 00:49
@JarbasAl JarbasAl merged commit f1a22ed into dev Jan 20, 2023
@JarbasAl JarbasAl deleted the refactor/skill_class_from_workshop branch January 20, 2023 03:09
@JarbasAl JarbasAl added this to the 0.0.6 milestone Jan 26, 2023
@JarbasAl JarbasAl added the enhancement New feature or request label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor code refactor without functional changes
Projects
None yet
Milestone
0.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@JarbasAl @NeonDaniel