Reorg shutdown to prevent logged exceptions in skill shutdown #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add try/except around module shutdown
Codecov Report
@@ Coverage Diff @@
## dev #240 +/- ##
==========================================
+ Coverage 50.35% 54.88% +4.53%
==========================================
Files 119 156 +37
Lines 10077 9357 -720
==========================================
+ Hits 5074 5136 +62
+ Misses 5003 4221 -782
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
j1nx
approved these changes
Dec 14, 2022
JarbasAl
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try/except around module shutdown