Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display settings ui #237

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix display settings ui #237

merged 1 commit into from
Dec 8, 2022

Conversation

AIIX
Copy link

@AIIX AIIX commented Dec 8, 2022

  • Moves display settings UI into a flickable and fixes overflow with a cleaner look and feel

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #237 (d6538b9) into dev (6ceb058) will increase coverage by 4.46%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##              dev     #237      +/-   ##
==========================================
+ Coverage   50.35%   54.81%   +4.46%     
==========================================
  Files         119      156      +37     
  Lines       10077     9318     -759     
==========================================
+ Hits         5074     5108      +34     
+ Misses       5003     4210     -793     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AIIX AIIX merged commit e96f11e into dev Dec 8, 2022
@AIIX AIIX deleted the fix/display-settings-ui branch December 8, 2022 02:20
@JarbasAl JarbasAl mentioned this pull request Jan 10, 2023
23 tasks
@JarbasAl JarbasAl added bug Something isn't working bug-ovos labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants