Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show_pages index api #234

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Fix show_pages index api #234

merged 2 commits into from
Nov 25, 2022

Conversation

AIIX
Copy link

@AIIX AIIX commented Nov 25, 2022

  • Show Pages index request was simply ignored in the API and always defaulted to activating the first page, instead of the requested index
  • Fixes page handling when index is specified along with list of pages in show_pages method call

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #234 (6cdc296) into dev (6ceb058) will increase coverage by 4.46%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##              dev     #234      +/-   ##
==========================================
+ Coverage   50.35%   54.81%   +4.46%     
==========================================
  Files         119      156      +37     
  Lines       10077     9318     -759     
==========================================
+ Hits         5074     5108      +34     
+ Misses       5003     4210     -793     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit 219f370 into dev Nov 25, 2022
@JarbasAl JarbasAl deleted the feat/fix_show_pages_api branch November 25, 2022 18:48
@JarbasAl JarbasAl mentioned this pull request Jan 10, 2023
23 tasks
@JarbasAl JarbasAl added the bug Something isn't working label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants