This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
With defaulting to
0.0.0.0:6712
we determine theurl
theDeviceApi
gets initialized with, resulting in configured backends inheriting this url and making api calls except (if url mismatch).with
None
passed the device api defaults toBackendType.OFFLINE
with the urlhttp://127.0.0.1
ovos-backend-client/ovos_backend_client/backends/__init__.py
Lines 53 to 67 in c0c8955
What i don't get why the default was set up effectively as
BackendType.PERSONAL
self.api_url
can be retrieved withself.api.backend_url