Fix: gstreamer top left corruption and states #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 73-byte corruption in the top left corner
The issue was caused by using void pointers
instead of the proper GStreamer memory
management functions. This led to memory
structures being saved in the output stream,
causing corruption in the top left corner.
Cleanup the code
Make the _chain function much simpler without
any lingering frames in the _mtltxsink
structure.
Add support for framebuffer argument
Add support for fps argument that overrides the
framerate of the capabilites.
Example usage:
gst-launch-1.0 videotestsrc location=$INPUT ! \
video/x-raw,format=I420,width=640,height=480 ! \
gstmtltxsink tx-queues=4 tx-udp-port=20000 \
tx-payload-type=112 dev-ip="192.168.96.3" \
tx-ip="239.168.75.30" dev-port="$DPDK_PORT" \
tx-fps=60
fixes: ed91d38c38b1b1571ec84826154c3ff8b8695ced
DawidWesierski4
force-pushed
the
fix_gstreamer
branch
from
33c81d4 to
de14554
Compare
Force the Gstreamer plugin into the PLAYING state to prevent reinitialization of the pipeline. This is achieved by disabling ASYNC state handling and manually setting the state to PLAYING. Additionally, send EOS when it is received, to signal the end of processing.
DawidWesierski4
changed the title
DawidWesierski4
requested review from
PanKaker,
Sakoram,
skolelis and
Falron98
as code owners
DawidWesierski4
commented
Dec 12, 2024
Dereference buffers inside mtl to improve memory efficiency of the pipeline.
MateuszGrabuszynski
approved these changes
Dec 12, 2024
Sakoram
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 73-byte corruption in the top left corner
The issue was caused by using void pointers
instead of the proper GStreamer memory
management functions. This led to memory
structures being saved in the output stream,
causing corruption in the top left corner.
Cleanup the code
Make the _chain function much simpler without
any lingering frames in the _mtltxsink
structure.
Add support for framebuffer argument
Add support for fps argument that overrides the
framerate of the capabilities.
Fix Ensure Gstreamer plugin reaches PLAYING state
Force the Gstreamer plugin into the PLAYING state
to prevent reinitialization of the pipeline.
This is achieved by disabling ASYNC state handling
and manually setting the state to PLAYING.
Additionally, send EOS when it is received,
to signal the end of processing.
Example usage:
gst-launch-1.0 videotestsrc location=$INPUT !
video/x-raw,format=I420,width=640,height=480 !
gstmtltxsink tx-queues=4 tx-udp-port=20000
tx-payload-type=112 dev-ip="192.168.96.3"
tx-ip="239.168.75.30" dev-port="$DPDK_PORT"
tx-fps=60
fixes: ed91d38c38b1b1571ec84826154c3ff8b8695ced