Add: simple st20tx plugin for gstreamer #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
force-pushed
the
gst-plugin
branch
from
c1565b7 to
529dfac
Compare
add simple st20tx plugin for gstreamer, allows for simple st2110 tx stream creation. Known bugs Tested against the ffmpeg st20 rx plugin and found corruption in the video stream. This is likely due to frame creation mechanizm in the _chain function Working on fixing it now
DawidWesierski4
force-pushed
the
gst-plugin
branch
from
529dfac to
fa85c0b
Compare
|
even though with ffmpeg -f \
rawvideo \
-video_size \
1920x1080 \
-pix_fmt \
yuv422p10le \
-i "$OUTPUT" \
-r 60 \
src/frames/debug%d.pngit reports 1440 frames 2.4 times over working on ironing out the quirks |
|
Also analysis of the binary files indicates i have a stable 0x90 Bytes offset in the data figuring it out why |
|
the data shift seem to originate from the data handed me by rawvideoparse format=y42b width=1920 height=1080 framerate=60/1It seems that this data is always the same added at the beginning |
|
Hi the issue was the format read the format wrong the y42b has 8bit depth https://gstreamer.freedesktop.org/documentation/additional/design/mediatype-video-raw.html?gi-language=c huge thx for Mateusz for noticing |
DawidWesierski4
force-pushed
the
gst-plugin
branch
from
02a33bd to
4150cc4
Compare
Add the status Fix the initialization Tested and there is an problem with small Corruption in the left top corner 73 x 9 pixels seem to be discolored and 1 x 9 pixels have quite big discoloration The initialization of plugin after the deinitialization needs to be fixed
DawidWesierski4
force-pushed
the
gst-plugin
branch
from
4150cc4 to
9ec3093
Compare
|
Ok ironed out most of the issue working on small corruption on left top corner in buxfix also -> the IMTL doesn't really mesh well with rapind init and deinit which we can address later |
DawidWesierski4
requested review from
PanKaker,
Sakoram,
skolelis and
Falron98
as code owners
MateuszGrabuszynski
suggested changes
Dec 6, 2024
ko80
reviewed
Dec 6, 2024
ko80
reviewed
Dec 6, 2024
DawidWesierski4
force-pushed
the
gst-plugin
branch
9 times, most recently
from
2fa23f3 to
809e672
Compare
DawidWesierski4
changed the title
DawidWesierski4
force-pushed
the
gst-plugin
branch
from
809e672 to
25165bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add simple st20tx plugin for gstreamer, allows for simple st2110 tx stream creation.
Known bugs
Tested against the ffmpeg st20 rx plugin and found corruption in the video stream. This is likely due to frame creation mechanizm in the _chain function
Working on fixing it now