Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ST2110 device parameters to reduce memory/time overhead #292

Merged

Conversation

tszumski
Copy link
Collaborator

Based on @DawidWesierski4 feedback we don't need more than 17 queue count, in result memory overhead and init time is reduced significantly

@DawidWesierski4
Copy link

Yes mtl backend supports up to 16 schedulers
without SHARED QUEUES flag every scheduler "gets" one queue

without support for more schedulers assigning 128 queues is just a waste of resources

when we will introduce support for more then 16 schedulers the conversation about increasing this number can come back

every scheduler takes
1 core from dpdk backend
1 queue to work with data

Copy link

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But i would use a define for that purpose

@tszumski tszumski marked this pull request as ready for review December 17, 2024 09:18
@tszumski tszumski force-pushed the tszumski-reduce-memory-overhead branch from c630c5b to 464e738 Compare December 17, 2024 12:41
Copy link

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tszumski tszumski force-pushed the tszumski-reduce-memory-overhead branch from 464e738 to 22142c3 Compare December 17, 2024 13:00
Copy link
Collaborator

@moleksy moleksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tszumski tszumski merged commit 3a1bb2b into OpenVisualCloud:main Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants