Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ST2110 bridge classes derived from Connection #261

Merged
merged 27 commits into from
Dec 3, 2024
Merged

Add ST2110 bridge classes derived from Connection #261

merged 27 commits into from
Dec 3, 2024

Conversation

tszumski
Copy link
Collaborator

  • Add new error code "error_shutdown",
  • Fix use of uninitialize value _link,
  • Fix clang compilation error - uuid.cc
  • Add ST2110 Rx/Tx 20/22/30 connections with basic UT

@tszumski tszumski force-pushed the tszumski-st2110-covvection-impl branch 2 times, most recently from 9e305dc to c6c135a Compare November 21, 2024 08:35
@tszumski tszumski force-pushed the tszumski-st2110-covvection-impl branch 2 times, most recently from 4d004d9 to 57285ae Compare November 21, 2024 10:46
@tszumski tszumski force-pushed the tszumski-st2110-covvection-impl branch from 5c3890f to 47ca913 Compare November 22, 2024 13:14
@ko80 ko80 changed the title Add ST2110 connections Add ST2110 bridge classes derived from Connection Nov 25, 2024
ko80
ko80 reviewed Nov 25, 2024
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
tszumski and others added 25 commits December 2, 2024 07:54
@tszumski
Add ST2110 Rx/Tx 20/22/30 connections with basic UT
ba5c36a 
Signed-off-by: Tomasz Szumski <[email protected]>
@tszumski
Adjust clang-format and apply it to st2110 files
030c4ef 
Signed-off-by: Tomasz Szumski <[email protected]>
@tszumski
Call shutdown() in destructor
8f3aa39
@tszumski
CI/CD quick fix. Disable MTL tests as hugepages are not set
ae8e31d
@tszumski
Replace std::function, with virtual fn in ST2110 derrived classes
2954106
@tszumski
Fix mutex
974051f
@tszumski
1. Free memory allocated by "strdup()"
2db96fc 
2. Rename _st to "mtl_device"
@tszumski
1. Remove prefix "_*" from class members name
cfdbb20 
2. Move class members to default initializer
3. Rename "handle" to "mtl_session"
4. Remove empty "private:" sections
@tszumski
1. Move empty constructor to header
0afaf08 
2. Do not inline functions in .cc files
@tszumski
Rework functions to return an error if the format is unknown.
e25952d
@tszumski
1. Initialze _ctx with context::WithCancel(context::Background());
d194ef1 
2. Fix ST2110Tx description
3. Add Check if st_frame_size() return error
4. Rework ST2110 configure() move as much as possible to base class
5. Fix session_id to be thread-safe
6. Rework configure() to use the structured logging feature.
@tszumski
Set sent variable only when data is actually sent.
1f0e0da
@tszumski
Set state Result::configured only if Result::success
3bf6fce
@tszumski
Rename variable "_sent" to "to_be_sent"
2bfc5b4
@tszumski
Format-coding applied based on updated clang-format
b29cdf8 
1. referenceAlignment: Left
2. BraceWrapping AfterFunction false
@tszumski
Fix log message
db06c5a
@tszumski
Use only atomic for synchronization
2dd4cd3
@tszumski
Rename error message
8d01718
@tszumski
Move varaibles to default initializers
80abcb0
@tszumski
Adjust code formatting
565e3fe
@tszumski
Fix synchronization based on std::atomic
e8a44f5
@tszumski
Fix setting state prematurely
c628077
@tszumski @ko80
Reorder loop
fa712dc 
Co-authored-by: Konstantin Ilichev <[email protected]>
Signed-off-by: Tomasz <[email protected]>
@tszumski
Remove redundant mesh:: namespace
ee85085
@tszumski
Add test scenarios for ST2110 transmit and receive following Concept.…
b154f4b 
…md scenario
@tszumski tszumski force-pushed the tszumski-st2110-covvection-impl branch from 43ee427 to b154f4b Compare December 2, 2024 07:55
@tszumski tszumski force-pushed the tszumski-st2110-covvection-impl branch from 94c59be to 2e7b582 Compare December 3, 2024 08:25
ko80
ko80 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ko80 ko80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Excellent job, Tomasz!

@tszumski tszumski merged commit 82d06a4 into OpenVisualCloud:main Dec 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakoram Sakoram Sakoram left review comments

@ko80 ko80 ko80 approved these changes

@pwysock1-intel pwysock1-intel Awaiting requested review from pwysock1-intel pwysock1-intel is a code owner

@soopel soopel Awaiting requested review from soopel soopel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tszumski @Sakoram @ko80