Prevent session data deletions #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stored our session data in an internal app directory. This meant that upon app deletion, all data in this directory was also removed, causing us to lose precious session data. To prevent this, we now store the session data in an external storage directory, provided we have been granted access to external storage. This change adds new utils to be able to do that as well as ensure consistency in the timestamped files such that all files will have names with the same timestamp, to allow for co-relation of the same session.
The app logs have not been moved in the external storage directory for now as they are more specific to the running of the app and it requires adding a wrapper around the existing log library to handle our outstanding promises for app directory creation. As that is not too urgent, it has been left for the future.
Close #119