Allow use of paths with spaces on Windows #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuli Seppänen <[email protected]>
mattock
commented
May 16, 2017
| rem copy in a fresh serial file so we begin generating keys at index 01 | ||
| copy serial.start %d%\serial. | ||
| copy serial.start "%d%\serial." |
There was a problem hiding this comment.
I'm not entirely sure what this line i supposed to do. Does it really just copy serial.start to serial.? What is the point of having the dot at the end of the filename?
mattock
commented
May 16, 2017
| rem test revocation | ||
| rem first concatinate ca cert with newly generated crl | ||
| copy %KEY_DIR%\ca.crt+%KEY_DIR%\crl.pem %KEY_DIR%\revoke_test_file.pem | ||
| copy "%KEY_DIR%\ca.crt"+"%KEY_DIR%\crl.pem" "%KEY_DIR%\revoke_test_file.pem" |
There was a problem hiding this comment.
According to this page the "+" operator concatenates files together. Is this the correct way to quote this command?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of quotes prevents placing easy-rsa into a directory which has spaces in its path, as reported by a user of ours.
These changes have not yet been tested at all, so consider this a discussion-only PR for now. Most of the changes should "just work", but there are a couple places where things could potentially break. I've added separate line comments in to these places.
Suggestions/improvements from people who have had to work with batch scripts are most welcome!