Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move git calls to /admin route #953

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 8, 2016

  • Make calls explicit to minimize possible accidental server trip during certain conditions. I would have combined these but with the server hit in Server down/stalled... #944 we are teetering with ENOMEM failures
  • Stray commas removed
  • Make some of the output pretty ... inversely related to Graceful failure #37
  • Reorder /admin route on most likely utilized FIFO
  • Move clone identify to /admin tools as well

NOTE
This should fix the main /about route from 500

Applies to #944

* Make calls explicit to minimize possible accidental server trip during certain conditions. I would have combined these but with the server hit in OpenUserJS#944 we are teetering with ENOMEM failures
* Stray commas removed
* Make some of the output pretty ... inversely related to OpenUserJS#37
* Reorder /admin route on most likely utilized FIFO
* Move clone identify to /admin tools as well

**NOTE**
This should fix the main /about route from 500

Applies to OpenUserJS#944
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 8, 2016
@Martii Martii merged commit aa6640d into OpenUserJS:master Apr 8, 2016
@Martii Martii deleted the Issue-944postChangeGitAPItoAdmin branch April 8, 2016 22:12
@Martii Martii added the bug You've guessed it... this means a bug is reported. label Apr 8, 2016
@Martii
Copy link
Member Author

Martii commented Apr 8, 2016

This should fix the main /about route from 500

Yes it does (at least right now)... added bug label

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant